[
https://issues.apache.org/jira/browse/FLINK-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629674#comment-16629674
]
ASF GitHub Bot commented on FLINK-10339:
----------------------------------------
zhijiangW commented on issue #6762: [FLINK-10339][network] Use off-heap memory
for SpillReadBufferPool
URL: https://github.com/apache/flink/pull/6762#issuecomment-424935982
Thanks for your reviews! @StephanEwen
That is a good idea for adding `allocateUnpooledOffHeapMemory` in the
factory, so it can also make easy for using in `MemoryManager` and
`NetworkBufferPool`. I already update the codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SpillReadBufferPool cannot use off-heap memory
> ----------------------------------------------
>
> Key: FLINK-10339
> URL: https://issues.apache.org/jira/browse/FLINK-10339
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.5.3, 1.6.0, 1.7.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> Currently, the {{NetworkBufferPool}} always uses off-heap memory to reduce
> memory copy from flink {{Buffer}} to netty internal {{ByteBuf}} during
> transporting on sender side.
>
> But for {{SpillReadBufferPool}} in {{SpilledSubpartitionView}}, it still uses
> heap memory for caching. We can make it as off-heap by default similar with
> {{NetworkBufferPool}} or decide the type by the current parameter
> {{taskmanager.memory.off-heap.}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
