TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r220779905
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java ########## @@ -429,7 +413,7 @@ public void testFailExternallyDuringInvoke() { awaitLatch.await(); task.failExternally(new Exception("test")); - assertTrue(task.getExecutionState() == ExecutionState.FAILED); Review comment: Oh I get your point, sorry for the delay. This is a bit about style, and I think both of them are OK. If there is a mandatory requirement on "not change that", I am ok to revert it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services