tillrohrmann commented on a change in pull request #6743: [FLINK-10411] Make
ClusterEntrypoint more compositional
URL: https://github.com/apache/flink/pull/6743#discussion_r220889317
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
##########
@@ -141,11 +144,11 @@ protected ClusterEntrypoint(Configuration configuration)
{
shutDownHook =
ShutdownHookUtil.addShutdownHook(this::cleanupDirectories,
getClass().getSimpleName(), LOG);
}
- public CompletableFuture<Void> getTerminationFuture() {
+ public CompletableFuture<ApplicationStatus> getTerminationFuture() {
return terminationFuture;
}
- protected void startCluster() {
+ protected void startCluster() throws ClusterEntrypointException {
Review comment:
Yes, you're right. I actually use it in a follow-up PR for testing purposes.
Would, thus, just keep it like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
