[ 
https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695213#comment-14695213
 ] 

ASF GitHub Bot commented on FLINK-2490:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/992#discussion_r36973430
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
 ---
    @@ -43,6 +43,7 @@
        private Socket socket;
        private static final int CONNECTION_TIMEOUT_TIME = 0;
        private static final int CONNECTION_RETRY_SLEEP = 1000;
    +   protected long retrys;
    --- End diff --
    
    You should also initialize the variable with 0 in the `open()` method.


> Remove unwanted boolean check in function 
> SocketTextStreamFunction.streamFromSocket
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-2490
>                 URL: https://issues.apache.org/jira/browse/FLINK-2490
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.10
>            Reporter: Huang Wei
>            Priority: Minor
>             Fix For: 0.10
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to