[
https://issues.apache.org/jira/browse/FLINK-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633672#comment-16633672
]
ASF GitHub Bot commented on FLINK-3875:
---------------------------------------
twalthr commented on a change in pull request #6611: [FLINK-3875] [connectors]
Add an upsert table sink factory for Elasticsearch
URL: https://github.com/apache/flink/pull/6611#discussion_r221513851
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/StreamTableDescriptor.scala
##########
@@ -96,6 +96,6 @@ class StreamTableDescriptor(
// this performs only basic validation
// more validation can only happen within a factory
- new StreamTableDescriptorValidator().validate(properties)
+ new StreamTableDescriptorValidator(true, true, true).validate(properties)
Review comment:
I think we can also remove it. As the comment suggests it doesn't check
much. Update modes are optional for custom factories anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a TableSink for Elasticsearch
> ---------------------------------
>
> Key: FLINK-3875
> URL: https://issues.apache.org/jira/browse/FLINK-3875
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors, Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> Add a TableSink that writes data to Elasticsearch
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
