Github user nltran commented on the pull request:
https://github.com/apache/flink/pull/967#issuecomment-130734997
The code now passes all the checks :smiley: I have addressed the previous
comments you made previously. @StephanEwen , @fhueske could you give it a
another review? Namely:
* The SSP slack configuration is now in TaskConfig instead of job-wide. At
some point we might want to unify both iterations strategies since the BSP
iteration mode is an edge case for SSP with the slack equal to zero.
* The parameter server is now completely orthogonal to Flink core. It is up
to the user to set it up and call it. I'm preparing a sample job that uses both
SSP and calls to a parameter server.
* Correct license header. Will I have to fill in a Contributor License
Agreement at some point?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
