[
https://issues.apache.org/jira/browse/FLINK-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636960#comment-16636960
]
ASF GitHub Bot commented on FLINK-10292:
----------------------------------------
tillrohrmann commented on issue #6786: [FLINK-10292][rest] Separate REST and
Dispatcher RPC thread pools
URL: https://github.com/apache/flink/pull/6786#issuecomment-426639274
Thanks for addressing some of my components @zentol. I think we should still
change how the `ExecutorService` is instantiated. Instead of doing it in the
constructor it should happen imo outside of the component. That way, we don't
couple different components (e.g. which `ExecutorService` is used by the
`WebMonitorEndpoint`). Moreover, it was already like this before and, thus, we
would introduce a regression (in terms of architecture).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Generate JobGraph in StandaloneJobClusterEntrypoint only once
> -------------------------------------------------------------
>
> Key: FLINK-10292
> URL: https://issues.apache.org/jira/browse/FLINK-10292
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.6.0, 1.7.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0, 1.6.2
>
>
> Currently the {{StandaloneJobClusterEntrypoint}} generates the {{JobGraph}}
> from the given user code every time it starts/is restarted. This can be
> problematic if the the {{JobGraph}} generation has side effects. Therefore,
> it would be better to generate the {{JobGraph}} only once and store it in HA
> storage instead from where to retrieve.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
