[ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638012#comment-16638012 ]
ASF GitHub Bot commented on FLINK-10386: ---------------------------------------- tillrohrmann commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener URL: https://github.com/apache/flink/pull/6729#discussion_r222605753 ########## File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java ########## @@ -181,43 +175,26 @@ */ @Test public void testEarlyCanceling() throws Exception { - Deadline deadline = Deadline.fromNow(Duration.ofMinutes(2)); - StreamConfig cfg = new StreamConfig(new Configuration()); + final StreamConfig cfg = new StreamConfig(new Configuration()); cfg.setOperatorID(new OperatorID(4711L, 42L)); cfg.setStreamOperator(new SlowlyDeserializingOperator()); cfg.setTimeCharacteristic(TimeCharacteristic.ProcessingTime); - Task task = createTask(SourceStreamTask.class, cfg, new Configuration()); + final TaskManagerActions taskManagerActions = mock(TaskManagerActions.class); Review comment: Might be orthogonal, but I think it is better to introduce a `TestingTaskManagerActions` where you can define the actions similar to `TestingResourceManagerGateway` or `TestingTaskExecutorGateway`. They both have builders to configure the behaviour. Then we would not need to mock things. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove legacy class TaskExecutionStateListener > ---------------------------------------------- > > Key: FLINK-10386 > URL: https://issues.apache.org/jira/browse/FLINK-10386 > Project: Flink > Issue Type: Sub-task > Components: TaskManager > Affects Versions: 1.7.0 > Reporter: tison > Assignee: tison > Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > > After a discussion > [here|https://github.com/apache/flink/commit/0735b5b935b0c0757943e2d58047afcfb9949560#commitcomment-30584257] > with [~trohrm...@apache.org]. I start to analyze the usage of > {{ActorGatewayTaskExecutionStateListener}} and {{TaskExecutionStateListener}}. > In conclusion, we abort {{TaskExecutionStateListener}} strategy and no any > component rely on it. Instead, we introduce {{TaskManagerActions}} to take > the role for the communication of {{Task}} with {{TaskManager}}. No one > except {{TaskManager}} should directly communicate with {{Task}}. So it can > be safely remove legacy class {{TaskExecutionStateListener}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)