Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/861#discussion_r37137570
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/MLUtils.scala ---
@@ -119,4 +120,30 @@ object MLUtils {
stringRepresentation.writeAsText(filePath)
}
+
+ /** Create a [[DataSet]] of [[OnlineHistogram]] from the input data
+ *
+ * @param bins Number of bins required. Zero for
[[CategoricalHistogram]]
+ * @param data input [[DataSet]] of [[Double]]
+ * @return [[DataSet]] of [[OnlineHistogram]]
+ */
+ private [ml] def createHistogram(data: DataSet[Double], bins: Int):
DataSet[OnlineHistogram] = {
+ val min = data.map(x => x).reduce((x,y) => Math.min(x,y))
+ val max = data.map(x => x).reduce((x,y) => Math.max(x,y))
--- End diff --
We don't need `map(x => x)` operation and need space between `x,` and `y`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
