[
https://issues.apache.org/jira/browse/FLINK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647722#comment-16647722
]
ASF GitHub Bot commented on FLINK-10126:
----------------------------------------
tillrohrmann commented on a change in pull request #6738: [FLINK-10126] There
should be a Scala DataSource
URL: https://github.com/apache/flink/pull/6738#discussion_r224731539
##########
File path: pom.xml
##########
@@ -1613,6 +1613,7 @@ under the License.
<exclude>org.apache.flink.api.scala.hadoop.mapred.HadoopOutputFormat</exclude>
<exclude>org.apache.flink.api.scala.hadoop.mapreduce.HadoopInputFormat</exclude>
<exclude>org.apache.flink.api.scala.hadoop.mapreduce.HadoopOutputFormat</exclude>
+
<exclude>org.apache.flink.api.scala.ExecutionEnvironment</exclude>
Review comment:
Would `org.apache.flink.api.scala.ExecutionEnvironment#createInput` work as
an exclusion? This is then more specific and would not exclude the complete
`ExecutionEnvironment`.
The danger is still that we would not detect any breaking API changes made
to these methods in the future. Could we maybe add a manual test which fails if
this happens and add a note stating why we have these tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> There should be a Scala DataSource
> ----------------------------------
>
> Key: FLINK-10126
> URL: https://issues.apache.org/jira/browse/FLINK-10126
> Project: Flink
> Issue Type: Improvement
> Reporter: Alexis Sarda-Espinosa
> Assignee: vinoyang
> Priority: Minor
> Labels: datasource, pull-request-available, scala
>
> In Java, an ExecutionEnvironment's createInput method returns a DataSource,
> whereas the Scala version returns a DataSet. There is no Scala DataSource
> wrapper, and the Scala DataSet does not provide the Java DataSource methods,
> such as getSplitDataProperties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
