[ https://issues.apache.org/jira/browse/FLINK-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698529#comment-14698529 ]
ASF GitHub Bot commented on FLINK-2529: --------------------------------------- GitHub user HuangWHWHW opened a pull request: https://github.com/apache/flink/pull/1022 [FLINK-2529][runtime]remove some unused code There are some reviews: 1.var consumerGraph is never used in public Boolean call() throws Exception. 2.In my learned knowledge, function Thread.currentThread() will never return null.So the code "shutdownHook != null" is unwanted. And i`m not complete sure.Maybe I`m wrong. You can merge this pull request into a Git repository by running: $ git pull https://github.com/HuangWHWHW/flink FLINK-2529 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1022.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1022 ---- commit f630fe9cf28ac734a472134d907e635693f00ad0 Author: HuangWHWHW <404823...@qq.com> Date: 2015-08-16T03:56:18Z [FLINK-2529][runtime]remove some unused code ---- > fix on some unused code for flink-runtime > ----------------------------------------- > > Key: FLINK-2529 > URL: https://issues.apache.org/jira/browse/FLINK-2529 > Project: Flink > Issue Type: Improvement > Components: Local Runtime > Affects Versions: 0.10 > Reporter: Huang Wei > Priority: Minor > Fix For: 0.10 > > Original Estimate: 168h > Remaining Estimate: 168h > -- This message was sent by Atlassian JIRA (v6.3.4#6332)