yanghua commented on a change in pull request #6703: [FLINK-9697] Provide
connector for Kafka 2.0.0
URL: https://github.com/apache/flink/pull/6703#discussion_r225022890
##########
File path:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/table/descriptors/KafkaValidator.java
##########
@@ -36,6 +36,7 @@
public static final String CONNECTOR_VERSION_VALUE_09 = "0.9";
public static final String CONNECTOR_VERSION_VALUE_010 = "0.10";
public static final String CONNECTOR_VERSION_VALUE_011 = "0.11";
+ public static final String CONNECTOR_VERSION_VALUE_20 = "2.0";
Review comment:
@aljoscha It's here. The kafka version will be verified in
KafkaValidator#validateVersion. I recommend removing the validation method and
refactoring this constant as:
```java
public static final String CONNECTOR_UNTRACKED_VERSION_VALUE = "untracked"
```
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
