yanghua commented on issue #6839: [FLINK-10253] Run MetricQueryService with 
lower priority
URL: https://github.com/apache/flink/pull/6839#issuecomment-429710107
 
 
   > One more question, should we expose the threads priority configuration to 
the user? The purpose of this pr is to lower the priority of metric query 
service, but the user can configure the threads priority to 10. Maybe we should 
at least restrict the maximum of threads priority. Before diving into the code, 
I am waiting for inputs from @tillrohrmann .
   
   I think the configuration provides flexibility, which allows us to make 
adjustments without changing the code. But the configuration brings the 
possibility of unreasonable settings, which is bound to exist. Users always 
have to pay for his actions if they ignore warnings. Of course, as a protective 
measure, limiting the maximum value he can set, sounds like a good idea. If 
@tillrohrmann  thinks this plan is worth adopting, then I will increase this 
limit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to