yanghua commented on a change in pull request #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL URL: https://github.com/apache/flink/pull/6736#discussion_r225090888
########## File path: docs/dev/table/functions.md ########## @@ -1219,6 +1219,18 @@ TAN(numeric) </td> </tr> + <tr> + <td> + {% highlight text %} +TANH(numeric) +{% endhighlight %} + </td> + <td> + <p>Returns the hyperbolic tangent of <i>NUMERIC</i>.</p> + <p>Return value type is <i>DOUBLE</i>.</p> Review comment: @pnowojski Yes, in cosh PR, @xccui has given this review suggestion. But because I submitted a lot of PRs, I forgot this suggestion, and you probably didn't pay attention to it (this is why I disscuss with xccui that if we review more efficiently and it would be easier to avoid this happening). In the end, I used that PR as a template. I think this question has been 100% clear. Respect your and @xccui 's review suggestions. Thank you again for your time and effort. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services