[ https://issues.apache.org/jira/browse/FLINK-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650824#comment-16650824 ]
ASF GitHub Bot commented on FLINK-10553: ---------------------------------------- xuefuz commented on issue #6847: [FLINK-10553] [sql] Unified sink and source table name in SQL statement URL: https://github.com/apache/flink/pull/6847#issuecomment-430020997 Hi Jerry, Thanks for fixing this. Your changes seems good. However, I have a side question: do we expect that the external catalog understands the notation of "catalog.db.table", that's is, three level hierarchy, or it just take the table name literally. From InMemoryExternalCatalog, it seems to me the catalog doesn't seem doing anything interpretation on the given table name. I'm not sure if I missed anything. (Nothing wrong about your changes, but just about my understanding.) Thanks, Xuefu ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Unified sink and source table name in SQL statement > --------------------------------------------------- > > Key: FLINK-10553 > URL: https://issues.apache.org/jira/browse/FLINK-10553 > Project: Flink > Issue Type: Bug > Components: Table API & SQL > Affects Versions: 1.6.0, 1.7.0 > Reporter: wangsan > Assignee: wangsan > Priority: Major > Labels: pull-request-available > > Since sink table can now be registered using ExternalCatalog, just the same > as source table, the source and sink name in SQL statement should also be > treated equally. Now we can only use `catalog.database.table` for sink table > (enclosed in back-ticks as a identifier), this is not consistent with source > table name (do not treat the whole name as a identifier). > *INSERT INTO catalog.database.sinktable SELECT ... FROM > catalog.database.sourcetable* should be supported . -- This message was sent by Atlassian JIRA (v7.6.3#76005)