zentol commented on a change in pull request #6850: [FLINK-10252] Handle
oversized metric messges
URL: https://github.com/apache/flink/pull/6850#discussion_r225411295
##########
File path:
flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/Metric.java
##########
@@ -18,8 +18,10 @@
package org.apache.flink.metrics;
+import java.io.Serializable;
+
/**
* Common super interface for all metrics.
*/
-public interface Metric {
+public interface Metric extends Serializable {
Review comment:
For transmission to the `MetricFetcher` metrics are serialized as a
`MetricSerializationResult` that contains a large byte array, for which it
should be trivial to determine the akka size, or at the very least whether it
fits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
