[ https://issues.apache.org/jira/browse/FLINK-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651388#comment-16651388 ]
ASF GitHub Bot commented on FLINK-10537: ---------------------------------------- pnowojski commented on a change in pull request #6833: [FLINK-10537][network] Fix network small performance degradation after merging [FLINK-9913] URL: https://github.com/apache/flink/pull/6833#discussion_r225462543 ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java ########## @@ -92,20 +92,9 @@ public void serializeRecord(T record) throws IOException { */ @Override public SerializationResult copyToBufferBuilder(BufferBuilder targetBuffer) { - boolean mustCommit = false; - if (lengthBuffer.hasRemaining()) { Review comment: I don't think it matters and it would complicate the code. In case of records spanning multiple buffers (3 or more), the cost of calling `targetBuffer.append(lengthBuffer)` multiple times would be very small compared to even the cost of copying `32KB` of data. If you also account the actual cost of serialising the record that size, this become even more unimportant. It could matters only if records are small and then the opposite is true (as our benchmarks are showing). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Network throughput performance regression after broadcast changes > ----------------------------------------------------------------- > > Key: FLINK-10537 > URL: https://issues.apache.org/jira/browse/FLINK-10537 > Project: Flink > Issue Type: Bug > Components: Network > Affects Versions: 1.7.0 > Reporter: Piotr Nowojski > Assignee: Piotr Nowojski > Priority: Major > Labels: pull-request-available > > There is a slight network throughput regression introduced in: > https://issues.apache.org/jira/browse/FLINK-9913 > It is visible in the following benchmark: > [http://codespeed.dak8s.net:8000/timeline/#/?exe=1&ben=networkThroughput.1,100ms&env=2&revs=200&equid=off&quarts=on&extr=on] > (drop in the chart that happened since 21st September.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)