[ https://issues.apache.org/jira/browse/FLINK-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651575#comment-16651575 ]
ASF GitHub Bot commented on FLINK-10252: ---------------------------------------- yanghua commented on a change in pull request #6850: [FLINK-10252] Handle oversized metric messges URL: https://github.com/apache/flink/pull/6850#discussion_r225508364 ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricQueryService.java ########## @@ -109,7 +122,17 @@ public void onReceive(Object message) { } } else if (message instanceof CreateDump) { MetricDumpSerialization.MetricSerializationResult dump = serializer.serialize(counters, gauges, histograms, meters); - getSender().tell(dump, getSelf()); + + int realMsgSize = dump.serializedMetrics.length; + + if (realMsgSize > maximumFramesize) { + String overSizeErrorMsg = "The metric dump message size : " + realMsgSize + + " exceeds the maximum akka framesize : " + maximumFramesize + "."; + LOG.error(overSizeErrorMsg); + getSender().tell(new Status.Failure(new IOException(overSizeErrorMsg)), getSelf()); Review comment: I want to confirm with you, here the serialize operation is called in the `MetricQueryService`, but if you want to unregister a metric, it will make the `MetricQueryService` depend on the `MetricRegistry` (this dependency is reasonable?), and the parameters required by the unregister method, they have not been saved in `MetricQueryService` classes. I am not sure if we want to introduce this complexity? Or still returning to the original idea to serialize only part of the metrics? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Handle oversized metric messges > ------------------------------- > > Key: FLINK-10252 > URL: https://issues.apache.org/jira/browse/FLINK-10252 > Project: Flink > Issue Type: Sub-task > Components: Metrics > Affects Versions: 1.5.3, 1.6.0, 1.7.0 > Reporter: Till Rohrmann > Assignee: vinoyang > Priority: Critical > Labels: pull-request-available > Fix For: 1.7.0, 1.6.2, 1.5.5 > > > Since the {{MetricQueryService}} is implemented as an Akka actor, it can only > send messages of a smaller size then the current {{akka.framesize}}. We > should check similarly to FLINK-10251 whether the payload exceeds the maximum > framesize and fail fast if it is true. -- This message was sent by Atlassian JIRA (v7.6.3#76005)