[
https://issues.apache.org/jira/browse/FLINK-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651845#comment-16651845
]
ASF GitHub Bot commented on FLINK-10565:
----------------------------------------
StefanRRichter commented on issue #6856: [FLINK-10565] [tests] Refactor
SchedulerTestBase
URL: https://github.com/apache/flink/pull/6856#issuecomment-430269266
Overall, the changes look good. Why exactly did you extract the inner
classes for this PR? I could not find any additional uses and it only makes the
review slightly harder. If we find a use case where extraction makes sense at
some point, we can extract them then. So I would suggest to revert the
extraction for now and then I would merge the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor SchedulerTestBase
> --------------------------
>
> Key: FLINK-10565
> URL: https://issues.apache.org/jira/browse/FLINK-10565
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.7.0
> Reporter: TisonKun
> Assignee: TisonKun
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> Basically, current {{SchedulerTestBase}} covers {{Scheduler}} tests, which is
> a schedule mechanism of legacy mode. We can remove it from
> {{SchedulerTestBase}}. Besides, inner {{SchedulerTestBase}} there are two
> useful testing class {{TestingSlotPool}} and {{TestingSlotPoolSlotProvider}}.
> Extract them for further usage.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
