twalthr commented on a change in pull request #6815: [FLINK-7062][cep][table] Added basic support for MATCH_RECOGNIZE URL: https://github.com/apache/flink/pull/6815#discussion_r225566799
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala ########## @@ -515,6 +519,23 @@ class RexTimeIndicatorMaterializerUtils(rexBuilder: RexBuilder) { input.getRowType.getFieldNames) } + def materializeTypes(relType: RelDataType, idxFilter: Int => Boolean): RelDataType = { Review comment: I would remove this parameter for now and call this `getRowTypeWithoutIndicators`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services