zentol commented on a change in pull request #6850: [FLINK-10252] Handle
oversized metric messges
URL: https://github.com/apache/flink/pull/6850#discussion_r226199797
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
##########
@@ -116,6 +116,7 @@ public AkkaRpcService(final ActorSystem actorSystem, final
Time timeout) {
maximumFramesize =
actorSystem.settings().config().getBytes(MAXIMUM_FRAME_SIZE_PATH);
} else {
// only local communication
+ // TODO : this is not a reasonable default.
Review comment:
Now that we know that this branch is for local communication this _is_ a
reasonable default since we never go through netty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
