[
https://issues.apache.org/jira/browse/FLINK-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655077#comment-16655077
]
ASF GitHub Bot commented on FLINK-10149:
----------------------------------------
GJL commented on a change in pull request #6557: [FLINK-10149] [flink-mesos]
Don't allocate extra mesos port for TM unless configured to do so.
URL: https://github.com/apache/flink/pull/6557#discussion_r226269500
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/LaunchableMesosWorker.java
##########
@@ -346,10 +346,12 @@ public String toString() {
final String portKeys = config.getString(PORT_ASSIGNMENTS);
- Arrays.stream(portKeys.split(","))
- .map(String::trim)
- .peek(key -> LOG.debug("Adding port key " + key + " to
mesos request"))
- .forEach(tmPortKeys::add);
+ if (portKeys != null) {
+ Arrays.stream(portKeys.split(","))
+ .map(String::trim)
+ .peek(key -> LOG.debug("Adding port key " + key
+ " to mesos request"))
Review comment:
Slf4j placeholders should be preferred, i.e., `LOG.debug("Adding port key {}
to mesos request", key)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fink Mesos allocates extra port when not configured to do so.
> -------------------------------------------------------------
>
> Key: FLINK-10149
> URL: https://issues.apache.org/jira/browse/FLINK-10149
> Project: Flink
> Issue Type: Bug
> Reporter: Rune Skou Larsen
> Assignee: Rune Skou Larsen
> Priority: Minor
> Labels: pull-request-available
>
> Internal testing has revealed a small bug in the way LaunchableMesosWorker
> handles the absense of the new *mesos.resourcemanager.tasks.port-assignments*
> config option.
> It allocates an extra mesos port even when the option is not set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
