yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add 
ASCII/CHR function for table/sql API
URL: https://github.com/apache/flink/pull/6432#discussion_r226520617
 
 

 ##########
 File path: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
 ##########
 @@ -252,6 +252,17 @@ object ScalarFunctions {
     regexp_extract(str, regex, 0)
   }
 
+  /**
+    * Returns a numeric value of the leftmost character of the string str.
+    */
+  def ascii(str: String): Integer = {
+    if (str == null || str.equals("")) {
+      0
+    } else {
+      str.charAt(0).toByte.toInt
 
 Review comment:
   I think it is really necessary to add an ASCII judgment here. I 
misunderstood what you mean. I thought you were talking about [this issue]( 
https://github.com/apache/flink/pull/6432#discussion_r205512482).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to