yanghua commented on a change in pull request #6816: [FLINK-10527] Cleanup
constant isNewMode in YarnTestBase
URL: https://github.com/apache/flink/pull/6816#discussion_r226526901
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java
##########
@@ -189,9 +189,9 @@ public void perJobYarnClusterOffHeap() throws IOException {
/**
* Test TaskManager failure and also if the vcores are set correctly
(see issue FLINK-2213).
*/
+ @Ignore
@Test(timeout = 100000) // timeout after 100 seconds
public void testTaskManagerFailure() throws Exception {
- assumeTrue("The new mode does not start TMs upfront.",
!isNewMode);
Review comment:
@tillrohrmann So, is your review suggestion still the same? Do we still need
to keep the isNewMode field? (About these methods, I have created a [separate
issue](https://issues.apache.org/jira/browse/FLINK-10558) to track them, I
think we will not forget them in the end).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
