zentol commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys URL: https://github.com/apache/flink/pull/6872#issuecomment-431256748 > If we now introduce a RestOption#DISPATCHER_ADDRESS with the fallback to RestOption#ADDRESS and JobManagerOptions#ADDRESS and remove the latter as a deprecated key from the former, then we break setups. > In the future, this might change and could require to remove the fallback dependency depending on what the default behaviour is. This also applies to your proposed solution for handling this issue in the future. Although ... is this really is an issue? We can change all usages within Flink to `DISPATCHER_ADDRESS` (which should be reasonable considering that we only ever go to the dispatcher via REST), with the exception of the `RestServerEndpoint` for which we map ' DISPATCHER_ADDRESS' to ' REST#ADDRESS'. What could this break? I can only come up with a custom `ClusterEntryPoint` that uses a `RestServerEndpoint` internally and no other Flink component that is aware of the configuration thingie, which seems unlikely?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
