[ 
https://issues.apache.org/jira/browse/FLINK-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656460#comment-16656460
 ] 

Till Rohrmann commented on FLINK-10569:
---------------------------------------

I think we need to replace the {{Scheduler}} with {{TestingSlotProvider}} or 
{{ProgrammedSlotProvider}} and replace the {{Instance}} with a {{LogicalSlot}} 
implementation which we can cancel. Maybe we need to add some more testing 
utilities for that but it should be doable.

> Clean up uses of Scheduler and Instance in valid tests
> ------------------------------------------------------
>
>                 Key: FLINK-10569
>                 URL: https://issues.apache.org/jira/browse/FLINK-10569
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.7.0
>            Reporter: TisonKun
>            Assignee: TisonKun
>            Priority: Major
>             Fix For: 1.7.0
>
>
> Legacy class {{Scheduler}} and {{Instance}} are still used in some valid 
> tests like {{ExecutionGraphRestartTest}}. We should replace them with FLIP-6 
> schedule mode. The best way I can find is use {{SimpleSlotProvider}}.
> Note that we need not to remove all use points among all files since most of 
> them stay in legacy codebase like {{JobManager.scala}} and would be removed 
> later.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to