Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1026#issuecomment-131767636
Looks mostly good.
The `TaskRuntimeInfo` is now a bit strange. It contains some runtime info
for tasks (attempt number) but not all (subtasks, etc). The attempt number is
in the `TaskDeploymentDescriptor` anyways, so why copy it in addition to the
`TaskRuntimeInfo`? Before, the `TaskManagerInfo` was clearly the context info
of the TaskManager that was the same for all tasks and there was no duplicate
information.
Looks like the motivation was to minimize the number of objects passed to
the `RuntimeContext`. In that case, why not create a `RuntimeInfo` for the task
(keep the `TaskManagerInfo`), put all the task-specific information in there,
pass it to the `RuntimeEnvironment` and `RuntimeContext` and let them return
all info like `getTaskName` and `getIndexOfThisSubtask` from there?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
