StefanRRichter commented on a change in pull request #6875: [FLINK-9808] [state 
backends] Migrate state when necessary in state backends
URL: https://github.com/apache/flink/pull/6875#discussion_r226690598
 
 

 ##########
 File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ##########
 @@ -1389,6 +1388,149 @@ private void copyStateDataHandleData(
                return Tuple2.of(stateInfo.f0, newMetaInfo);
        }
 
+       private <N, S extends State, SV> 
RegisteredKeyValueStateBackendMetaInfo<N, SV> migrateStateIfNecessary(
 
 Review comment:
   I have an ongoing effort to shrink the size of the 
`RocksDBKeyedStateBackend` class. I think it is a good idea to move the 
migration concern in a separate class file if possible to keep different 
concerns more separated whereever possible. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to