[
https://issues.apache.org/jira/browse/FLINK-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657215#comment-16657215
]
ASF GitHub Bot commented on FLINK-10614:
----------------------------------------
tillrohrmann closed pull request #6884: [FLINK-10614] Let
test_batch_allround.sh rely on test-runner-common.sh for clean up
URL: https://github.com/apache/flink/pull/6884
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/flink-end-to-end-tests/test-scripts/test_batch_allround.sh
b/flink-end-to-end-tests/test-scripts/test_batch_allround.sh
index 2bb274b9557..f8f591f7dc0 100755
--- a/flink-end-to-end-tests/test-scripts/test_batch_allround.sh
+++ b/flink-end-to-end-tests/test-scripts/test_batch_allround.sh
@@ -24,30 +24,12 @@
TEST_PROGRAM_JAR=${END_TO_END_DIR}/flink-dataset-allround-test/target/DataSetAll
echo "Run DataSet-Allround-Test Program"
# modify configuration to include spilling to disk
-cp $FLINK_DIR/conf/flink-conf.yaml $FLINK_DIR/conf/flink-conf.yaml.bak
echo "taskmanager.network.memory.min: 10485760" >>
$FLINK_DIR/conf/flink-conf.yaml
echo "taskmanager.network.memory.max: 10485760" >>
$FLINK_DIR/conf/flink-conf.yaml
set_conf_ssl
start_cluster
-$FLINK_DIR/bin/taskmanager.sh start
-$FLINK_DIR/bin/taskmanager.sh start
-$FLINK_DIR/bin/taskmanager.sh start
-
-function test_cleanup {
- # don't call ourselves again for another signal interruption
- trap "exit -1" INT
- # don't call ourselves again for normal exit
- trap "" EXIT
-
- stop_cluster
- $FLINK_DIR/bin/taskmanager.sh stop-all
-
- # revert our modifications to the Flink distribution
- mv -f $FLINK_DIR/conf/flink-conf.yaml.bak $FLINK_DIR/conf/flink-conf.yaml
-}
-trap test_cleanup INT
-trap test_cleanup EXIT
+start_taskmanagers 3
$FLINK_DIR/bin/flink run -p 4 $TEST_PROGRAM_JAR --loadFactor 4 --outputPath
$TEST_DATA_DIR/out/dataset_allround
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update test_batch_allround.sh e2e to new testing infrastructure
> ---------------------------------------------------------------
>
> Key: FLINK-10614
> URL: https://issues.apache.org/jira/browse/FLINK-10614
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.4, 1.6.1, 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.5.6, 1.6.3, 1.7.0
>
>
> The {{test_batch_allround.sh}} still does clean up tasks which is done by the
> {{test-runner-common.sh}}. This is no longer needed and should be the
> responsibility of the latter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
