NicoK commented on a change in pull request #6705: [FLINK-10356][network] add
sanity checks to SpillingAdaptiveSpanningRecordDeserializer
URL: https://github.com/apache/flink/pull/6705#discussion_r226984032
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java
##########
@@ -137,7 +162,16 @@ else if (remaining == 0) {
// spanning record case
if (this.spanningWrapper.hasFullRecord()) {
// get the full record
- target.read(this.spanningWrapper.getInputView());
+ try {
+
target.read(this.spanningWrapper.getInputView());
+ } catch (EOFException e) {
+ Optional<String> deserializationError =
this.spanningWrapper.getDeserializationError(1);
Review comment:
For the first part, see above.
Regarding the number of checks: basically, the
`spanningWrapper.getDeserializationError(1)` check is for the case where we
tried to consume more bytes than available,
`spanningWrapper.getDeserializationError(0)` for the case where we did not
consume all bytes we were supposed to consume. Only one of the two checks will
be executed in any case.
-> I hope, this will become clearer after the refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
