[jira] [Commented] (FLINK-9737) Allow to define Table Version Functions from SQL environment file

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-9737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659497#comment-16659497
 ] 

ASF GitHub Bot commented on FLINK-9737:
---------------------------------------

dawidwys commented on a change in pull request #6897: [FLINK-9737] [FLINK-8880] 
[sql-client] Support defining temporal tables in environment files
URL: https://github.com/apache/flink/pull/6897#discussion_r227000607
 
 

 ##########
 File path: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
 ##########
 @@ -42,99 +45,72 @@
  */
 public class Environment {
 
-       private Map<String, TableDescriptor> tables;
+       public static final String EXECUTION = "execution";
 
 Review comment:
   nit: `EXECUTION` -> `EXECUTION_(ENTRY)_KEY`? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow to define Table Version Functions from SQL environment file
> -----------------------------------------------------------------
>
>                 Key: FLINK-9737
>                 URL: https://issues.apache.org/jira/browse/FLINK-9737
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.5.0
>            Reporter: Piotr Nowojski
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> It should be possible to define TVF from SQL environment file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)