zhijiangW commented on a change in pull request #6705: [FLINK-10356][network]
add sanity checks to SpillingAdaptiveSpanningRecordDeserializer
URL: https://github.com/apache/flink/pull/6705#discussion_r227286509
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializationTest.java
##########
@@ -104,11 +116,216 @@ public void testHandleMixedLargeRecords() throws
Exception {
testSerializationRoundTrip(originalRecords, segmentSize);
}
+ /**
+ * Non-spanning, deserialization reads one byte too many and succeeds.
+ */
+ @Test
+ public void testHandleDeserializingTooMuchNonSpanning1() throws
Exception {
+ expectedException.expect(IOException.class);
+ expectedException.expectMessage(" -1 remaining unread byte");
+ testHandleWrongDeserialization(new
StringValueDeserializingTooMuch("Test string"), 32 * 1024);
+ }
+
+ /**
+ * Non-spanning, serialization length is 16 (including headers),
deserialization reads one byte
+ * too many and succeeds.
+ */
+ @Test
+ public void testHandleDeserializingTooMuchNonSpanning2() throws
Exception {
+ expectedException.expect(IOException.class);
+ expectedException.expectMessage(" -1 remaining unread byte");
+ testHandleWrongDeserialization(new
StringValueDeserializingTooMuch("Test string"), 17);
Review comment:
This test can be merged with above
`testHandleDeserializingTooMuchNonSpanning1()` by adding
`testHandleWrongDeserialization(new StringValueDeserializingTooMuch("Test
string"), 17)` at last? Because the `expectedException` is same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
