[
https://issues.apache.org/jira/browse/FLINK-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660892#comment-16660892
]
ASF GitHub Bot commented on FLINK-10431:
----------------------------------------
tillrohrmann commented on a change in pull request #6898: [FLINK-10431]
Extraction of scheduling-related code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227450458
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/AllocatedSlotActions.java
##########
@@ -39,10 +38,23 @@
* @param slotRequestId identifying the slot to release
* @param slotSharingGroupId identifying the slot sharing group to
which the slot belongs, null if none
* @param cause of the slot release, null if none
- * @return Acknowledge (future) after the slot has been released
+ * @return Acknowledge after the slot has been released
*/
- CompletableFuture<Acknowledge> releaseSlot(
+ @Deprecated
+ Acknowledge releaseSlot(
SlotRequestId slotRequestId,
@Nullable SlotSharingGroupId slotSharingGroupId,
@Nullable Throwable cause);
+
+ /**
+ * Releases the slot with the given {@link SlotRequestId}.
Additionally, one can provide a cause for the slot release.
+ *
+ * @param slotRequestId identifying the slot to release
+ * @param cause of the slot release, null if none
+ * @return Acknowledge after the slot has been released
+ */
+ @Nonnull
+ Acknowledge releaseSlot(
Review comment:
Same here with `void`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Extract scheduling-related code from SlotPool
> ---------------------------------------------
>
> Key: FLINK-10431
> URL: https://issues.apache.org/jira/browse/FLINK-10431
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.7.0
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Major
> Labels: pull-request-available
>
> The other half of the current scheduling logic is the management of slot
> sharing and is located in the SlotPool. We need to extract this logic into
> our new Scheduler component from the previous step. This leaves us with a
> simpler SlotPool that mainly cares about obtaining, holding, and releasing
> slots in interaction with a ResourceManager. The new Scheduler can now
> identify slot sharing groups and interacts with the SlotPool.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
