[ 
https://issues.apache.org/jira/browse/FLINK-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660994#comment-16660994
 ] 

ASF GitHub Bot commented on FLINK-10490:
----------------------------------------

StefanRRichter opened a new pull request #6910: [FLINK-10490][tests] 
OperatorSnapshotUtil should use SavepointV2Seria…
URL: https://github.com/apache/flink/pull/6910
 
 
   ## Brief change log
   
   Methods in `OperatorSnapshotUtil` that are used in current tests are still 
based on the outdated `SavepointV1Serializer`. This PR updates this to the 
current `SavepointV2Serializer`.
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
   Change is only relevant for tests.
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> OperatorSnapshotUtil should probably use SavepointV2Serializer
> --------------------------------------------------------------
>
>                 Key: FLINK-10490
>                 URL: https://issues.apache.org/jira/browse/FLINK-10490
>             Project: Flink
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 1.7.0
>            Reporter: Stefan Richter
>            Priority: Major
>              Labels: pull-request-available
>
> {{OperatorSnapshotUtil}} is used for testing savepoint migration. This 
> utility internally still uses {{SavepointV1Serializer}} and I would assume 
> that it should use {{SavepointV2Serializer}}. I wonder if that means that 
> some newer cases are actually not covered in the migration tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to