[
https://issues.apache.org/jira/browse/FLINK-10656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662592#comment-16662592
]
ASF GitHub Bot commented on FLINK-10656:
----------------------------------------
isunjin commented on a change in pull request #6911: [FLINK-10656] Refactor
org.apache.flink.runtime.io.network.api.reader…
URL: https://github.com/apache/flink/pull/6911#discussion_r227888205
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/reader/TaskEventSender.java
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.api.reader;
+
+import org.apache.flink.runtime.event.TaskEvent;
+
+import java.io.IOException;
+
+/**
+ * The basic API for every reader.
+ */
+public interface TaskEventSender {
+
+ void sendTaskEvent(TaskEvent event) throws IOException;
Review comment:
Yeah, maybe we just simply change the name of ```ReaderBase``` to
```IterationReader```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor org.apache.flink.runtime.io.network.api.reader.ReaderBase
> ------------------------------------------------------------------
>
> Key: FLINK-10656
> URL: https://issues.apache.org/jira/browse/FLINK-10656
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Reporter: JIN SUN
> Assignee: JIN SUN
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.8.0
>
>
> The interface of org.apache.flink.runtime.io.network.api.reader.ReaderBase is
> not very clean, the API in it are called only by iteration and handle event.
> which is not related the name ReaderBase. And the functionality is
> independent, so propose to change the name and split the interface to two
> isolated interface.
> More details please look at the PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
