xuefuz commented on a change in pull request #6906: [Flink-6036][table]Let catalog support partition. URL: https://github.com/apache/flink/pull/6906#discussion_r227908967
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala ########## @@ -31,6 +31,32 @@ import org.apache.flink.table.api._ */ trait ExternalCatalog { + /** + * Gets the partition from external Catalog + * + * @param tableName table name + * @param partSpec partition specification + * @throws TableNotExistException if table does not exist in the catalog yet + * @throws PartitionNotExistException if partition does not exist in the catalog yet + * @return found partition + */ + @throws[TableNotExistException] + @throws[PartitionNotExistException] + def getPartition( + tableName: String, + partSpec: JLinkedHashMap[String, String]): ExternalCatalogPartition + + /** + * Gets the partition specification list of a table from external catalog + * + * @param tableName table name + * @throws CatalogNotExistException if database does not exist in the catalog yet Review comment: This (CatalogNotExistException) seems not needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services