yanghua commented on a change in pull request #6924: [FLINK-10600] Provide End-to-end test cases for modern Kafka connectors URL: https://github.com/apache/flink/pull/6924#discussion_r228505807
########## File path: flink-end-to-end-tests/test-scripts/test-data/modern-kafka-common.sh ########## @@ -0,0 +1,152 @@ +#!/usr/bin/env bash +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +set -o pipefail + +if [[ -z $TEST_DATA_DIR ]]; then + echo "Must run common.sh before modern-kafka-common.sh." + exit 1 +fi + +KAFKA_DIR=$TEST_DATA_DIR/kafka_2.11-2.0.0 +CONFLUENT_DIR=$TEST_DATA_DIR/confluent-5.0.0 +SCHEMA_REGISTRY_PORT=8082 +SCHEMA_REGISTRY_URL=http://localhost:${SCHEMA_REGISTRY_PORT} + +function setup_kafka_dist { + # download Kafka + mkdir -p $TEST_DATA_DIR + KAFKA_URL="https://archive.apache.org/dist/kafka/2.0.0/kafka_2.11-2.0.0.tgz"; + echo "Downloading Kafka from $KAFKA_URL" + curl "$KAFKA_URL" > $TEST_DATA_DIR/modern-kafka.tgz + + tar xzf $TEST_DATA_DIR/modern-kafka.tgz -C $TEST_DATA_DIR/ + + # fix kafka config + sed -i -e "s+^\(dataDir\s*=\s*\).*$+\1$TEST_DATA_DIR/zookeeper+" $KAFKA_DIR/config/zookeeper.properties + sed -i -e "s+^\(log\.dirs\s*=\s*\).*$+\1$TEST_DATA_DIR/kafka+" $KAFKA_DIR/config/server.properties +} + +function setup_confluent_dist { Review comment: Yes, I know. My strategy is divided into two steps: 1) First ensure that the end-to-end test passes; 2) Refactor it, still use the original `kafka-common`, and finally there should be no `modern-kafka-common` Currently I am working on the first problem (the wrong dependency version causes the class to not be found). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
