[ 
https://issues.apache.org/jira/browse/FLINK-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666993#comment-16666993
 ] 

ASF GitHub Bot commented on FLINK-10600:
----------------------------------------

pnowojski commented on a change in pull request #6924: [FLINK-10600] Provide 
End-to-end test cases for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#discussion_r228870191
 
 

 ##########
 File path: flink-examples/flink-examples-streaming/pom.xml
 ##########
 @@ -568,6 +585,49 @@ under the License.
                                                </configuration>
                                        </execution>
 
+                                       <execution>
+                                               <id>fat-jar-kafka-example</id>
+                                               <phase>package</phase>
+                                               <goals>
+                                                       <goal>shade</goal>
+                                               </goals>
+                                               <configuration>
+                                                       
<shadeTestJar>false</shadeTestJar>
+                                                       
<shadedArtifactAttached>false</shadedArtifactAttached>
+                                                       
<createDependencyReducedPom>false</createDependencyReducedPom>
+                                                       <transformers>
+                                                               <transformer 
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+                                                                       
<mainClass>org.apache.flink.streaming.examples.kafka.KafkaExample</mainClass>
+                                                               </transformer>
+                                                       </transformers>
+                                                       
<finalName>KafkaExample</finalName>
+                                                       <!-- 
<outputFile>Kafka.jar</outputFile> -->
 
 Review comment:
   Why do we need this comment? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Provide End-to-end test cases for modern Kafka connectors
> ---------------------------------------------------------
>
>                 Key: FLINK-10600
>                 URL: https://issues.apache.org/jira/browse/FLINK-10600
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Kafka Connector
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to