pnowojski commented on a change in pull request #6924: [FLINK-10600] Provide 
End-to-end test cases for modern Kafka connectors
URL: https://github.com/apache/flink/pull/6924#discussion_r228949560
 
 

 ##########
 File path: flink-examples/flink-examples-streaming/pom.xml
 ##########
 @@ -538,6 +550,11 @@ under the License.
                                                        <goal>shade</goal>
                                                </goals>
                                                <configuration>
+                                                       <artifactSet>
+                                                               <excludes>
+                                                                       
<exclude>org.apache.flink:flink-connector-kafka_${scala.binary.version}</exclude>
 
 Review comment:
   Ok, right. We can only exclude the modern one and `0.11`? And we can still 
exclude everything from "modern" `KafkaExample`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to