tillrohrmann commented on a change in pull request #6961: [FLINK-9635] Fix
scheduling for local recovery
URL: https://github.com/apache/flink/pull/6961#discussion_r229250429
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -902,14 +905,14 @@ public void scheduleForExecution() throws JobException {
private CompletableFuture<Void> scheduleLazy(SlotProvider slotProvider)
{
final ArrayList<CompletableFuture<Void>> schedulingFutures =
new ArrayList<>(numVerticesTotal);
-
// simply take the vertices without inputs.
for (ExecutionJobVertex ejv : verticesInCreationOrder) {
if (ejv.getJobVertex().isInputVertex()) {
final CompletableFuture<Void>
schedulingJobVertexFuture = ejv.scheduleAll(
slotProvider,
allowQueuedScheduling,
- LocationPreferenceConstraint.ALL); //
since it is an input vertex, the input based location preferences should be
empty
+ LocationPreferenceConstraint.ALL,//
since it is an input vertex, the input based location preferences should be
empty
+ Collections.emptySet()); // we provide
empty set because we currently don't want to trigger a computation in the batch
case
Review comment:
Comment could be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
