[ 
https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701814#comment-14701814
 ] 

ASF GitHub Bot commented on FLINK-2488:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1026#issuecomment-132322001
  
    Sorry to be picky again, but it would be good to harmonize the code style a 
bit - make it more consistent with the remaining code.
    
    What struck me in particular the omission of space before the curly braces 
at the start of methods and other code blocks. All other parts of the code have 
that.
    
    There are ongoing discussions about making the code style stricter (also 
with respect to white spaces), and this is much easier if new code follows this 
standard already. Otherwise, there'd going to be a lot of style adjustments 
necessary when introducing the check.


> Expose attemptNumber in RuntimeContext
> --------------------------------------
>
>                 Key: FLINK-2488
>                 URL: https://issues.apache.org/jira/browse/FLINK-2488
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager, TaskManager
>    Affects Versions: 0.10
>            Reporter: Robert Metzger
>            Assignee: Sachin Goel
>            Priority: Minor
>
> It would be nice to expose the attemptNumber of a task in the 
> {{RuntimeContext}}. 
> This would allow user code to behave differently in restart scenarios.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to