[
https://issues.apache.org/jira/browse/FLINK-10704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669851#comment-16669851
]
ASF GitHub Bot commented on FLINK-10704:
----------------------------------------
pnowojski commented on a change in pull request #6963: [FLINK-10704] Fix sql
client end to end test failure
URL: https://github.com/apache/flink/pull/6963#discussion_r229627265
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -316,7 +316,7 @@ function check_logs_for_errors {
| grep -v "java.lang.NoClassDefFoundError:
org/apache/hadoop/yarn/exceptions/YarnException" \
| grep -v "java.lang.NoClassDefFoundError:
org/apache/hadoop/conf/Configuration" \
| grep -v
"org.apache.flink.fs.shaded.hadoop3.org.apache.commons.beanutils.FluentPropertyBeanIntrospector
- Error when creating PropertyDescriptor for public final void
org.apache.flink.fs.shaded.hadoop3.org.apache.commons.configuration2.AbstractConfiguration.setProperty(java.lang.String,java.lang.Object)!
Ignoring this property." \
- | grep -ic "error")
+ | grep -c "ERROR")
Review comment:
Initially I though about ignoring all warnings, since it seemed to me as a
better solution compared to changing the behaviour of case sensitiveness
globally. But Then I realised that there are already way too many exclusions
hardcoded in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix sql client end to end test failure
> --------------------------------------
>
> Key: FLINK-10704
> URL: https://issues.apache.org/jira/browse/FLINK-10704
> Project: Flink
> Issue Type: Bug
> Components: E2E Tests, Kafka Connector
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Major
> Labels: pull-request-available
>
> The log file contains the following sentence:
> {code:java}
> 2018-10-29 03:27:39,209 WARN
> org.apache.flink.kafka010.shaded.org.apache.kafka.common.utils.AppInfoParser
> - Error while loading kafka-version.properties :null
> {code}
> The reason for this log is that we explicitly exclude the version description
> file of the kafka client when packaging the connector:
> {code:java}
> <filters>
> <filter>
> <artifact>*:*</artifact>
> <excludes>
> <exclude>kafka/kafka-version.properties</exclude>
> </excludes>
> </filter>
> </filters>{code}
> When the shell scan the "error" keyword with grep, it will hit, so the test
> will fail.
> {code:java}
> function check_logs_for_errors {
> error_count=$(grep -rv "GroupCoordinatorNotAvailableException"
> $FLINK_DIR/log \
> | grep -v "RetriableCommitFailedException" \
> | grep -v "NoAvailableBrokersException" \
> | grep -v "Async Kafka commit failed" \
> | grep -v "DisconnectException" \
> | grep -v "AskTimeoutException" \
> | grep -v "WARN akka.remote.transport.netty.NettyTransport" \
> | grep -v "WARN
> org.apache.flink.shaded.akka.org.jboss.netty.channel.DefaultChannelPipeline" \
> | grep -v "jvm-exit-on-fatal-error" \
> | grep -v '^INFO:.*AWSErrorCode=\[400 Bad
> Request\].*ServiceEndpoint=\[https://.*\.s3\.amazonaws\.com\].*RequestType=\[HeadBucketRequest\]'
> \
> | grep -v "RejectedExecutionException" \
> | grep -v "An exception was thrown by an exception handler" \
> | grep -v "java.lang.NoClassDefFoundError:
> org/apache/hadoop/yarn/exceptions/YarnException" \
> | grep -v "java.lang.NoClassDefFoundError:
> org/apache/hadoop/conf/Configuration" \
> | grep -v
> "org.apache.flink.fs.shaded.hadoop3.org.apache.commons.beanutils.FluentPropertyBeanIntrospector
> - Error when creating PropertyDescriptor for public final void
> org.apache.flink.fs.shaded.hadoop3.org.apache.commons.configuration2.AbstractConfiguration.setProperty(java.lang.String,java.lang.Object)!
> Ignoring this property." \
> | grep -ic "error") //here
> if [[ ${error_count} -gt 0 ]]; then
> echo "Found error in log files:"
> cat $FLINK_DIR/log/*
> EXIT_CODE=1
> fi
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
