[
https://issues.apache.org/jira/browse/FLINK-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670097#comment-16670097
]
ASF GitHub Bot commented on FLINK-4582:
---------------------------------------
tweise commented on a change in pull request #6968: [FLINK-4582] Consuming data
from DynamoDB streams to flink
URL: https://github.com/apache/flink/pull/6968#discussion_r229688269
##########
File path:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/dynamodbstreams/model/DynamodbStreamsShardHandleTest.java
##########
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.dynamodbstreams.model;
+
+import org.junit.Test;
+
+import static
org.apache.flink.streaming.connectors.dynamodbstreams.model.DynamodbStreamsShardHandle.SHARDID_PREFIX;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+/**
+ * Shard handle unit tests.
+ */
+public class DynamodbStreamsShardHandleTest {
+ @Test
+ public void testIsValidShardId() {
+ // normal form
+ String shardId = "shardId-00000001536805703746-69688cb1";
+ assertEquals(true,
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+ // short form
+ shardId = "shardId-00000001536805703746";
+ assertEquals(true,
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+ // long form
+ shardId =
"shardId-00000001536805703746-69688cb1aljkwerijfl8228sl12a123akfla";
+ assertEquals(true,
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+ // invalid with wrong prefix
+ shardId = "sId-00000001536805703746-69688cb1";
+ assertEquals(false,
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+ // invalid with non-digits
+ shardId = "shardId-0000000153680570aabb-69688cb1";
+ assertEquals(false,
DynamodbStreamsShardHandle.isValidShardId(shardId));
+
+ // invalid with shardId too long
+ shardId =
"shardId-00000001536805703746-69688cb1aljkwerijfl8228sl12a123akfla0000";
+ assertEquals(false,
DynamodbStreamsShardHandle.isValidShardId(shardId));
+ }
+
+ @Test
+ public void testCompareShardId() {
+ final int numShardIds = 10;
+ final int shardIdDigitLen = 20;
+ final String zeros = "00000000000000000000"; // twenty '0'
chars
+ String shardIdValid = "shardId-00000001536805703746-69688cb1";
+ String shardIdInvalid = "shardId-0000000153680570aabb-69688cb1";
+
+ assertEquals(0,
DynamodbStreamsShardHandle.compareShardIds(shardIdValid, shardIdValid));
+
+ // comparison of invalid shardIds should yield exception
+ try {
+
DynamodbStreamsShardHandle.compareShardIds(shardIdValid, shardIdInvalid);
+ fail("invalid shard Id" + shardIdInvalid + " should
trigger exception");
+ } catch (IllegalArgumentException e) {
+ // ignore
+ }
+ try {
+
DynamodbStreamsShardHandle.compareShardIds(shardIdInvalid, shardIdValid);
+ fail("invalid shard Id" + shardIdInvalid + " should
trigger exception");
+ } catch (IllegalArgumentException e) {
+ // ignore
Review comment:
this should be `// expected` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow FlinkKinesisConsumer to adapt for AWS DynamoDB Streams
> ------------------------------------------------------------
>
> Key: FLINK-4582
> URL: https://issues.apache.org/jira/browse/FLINK-4582
> Project: Flink
> Issue Type: New Feature
> Components: Kinesis Connector, Streaming Connectors
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Ying Xu
> Priority: Major
> Labels: pull-request-available
>
> AWS DynamoDB is a NoSQL database service that has a CDC-like (change data
> capture) feature called DynamoDB Streams
> (http://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Streams.html),
> which is a stream feed of item-level table activities.
> The DynamoDB Streams shard abstraction follows that of Kinesis Streams with
> only a slight difference in resharding behaviours, so it is possible to build
> on the internals of our Flink Kinesis Consumer for an exactly-once DynamoDB
> Streams source.
> I propose an API something like this:
> {code}
> DataStream dynamoItemsCdc =
> FlinkKinesisConsumer.asDynamoDBStream(tableNames, schema, config)
> {code}
> The feature adds more connectivity to popular AWS services for Flink, and
> combining what Flink has for exactly-once semantics, out-of-core state
> backends, and queryable state with CDC can have very strong use cases. For
> this feature there should only be an extra dependency to the AWS Java SDK for
> DynamoDB, which has Apache License 2.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
