[ 
https://issues.apache.org/jira/browse/FLINK-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673430#comment-16673430
 ] 

ASF GitHub Bot commented on FLINK-10633:
----------------------------------------

zentol commented on issue #7003: [FLINK-10633][prometheus] Add E2E test
URL: https://github.com/apache/flink/pull/7003#issuecomment-435447361
 
 
   For one this was an experiment; I hated writing this test in bash, so 
instead I ported it to java. We may use it for future tests, we may rework it 
entirely. But from what I've seen things get done significantly faster if at 
least you have some starting point. The majority of the code here is sane and 
easily re-usable in whatever direction we want to go with. The mistake we did 
in the past was to jump ahead at the first stuff we came up with (our bash 
stuff) and not critically analyze it when doing so.
   
   Furthermore, I don't consider this a framework. It's too simply for that, 
all it adds is a programmatic way to interact with flink-dist. That's it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> End-to-end test: Prometheus reporter
> ------------------------------------
>
>                 Key: FLINK-10633
>                 URL: https://issues.apache.org/jira/browse/FLINK-10633
>             Project: Flink
>          Issue Type: Sub-task
>          Components: E2E Tests
>    Affects Versions: 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Add an end-to-end test using the {{PrometheusReporter}} to verify that all 
> metrics are properly reported. Additionally verify that the newly introduce 
> RocksDB metrics are accessible (see FLINK-10423).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to