[
https://issues.apache.org/jira/browse/FLINK-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674814#comment-16674814
]
ASF GitHub Bot commented on FLINK-10772:
----------------------------------------
tillrohrmann commented on issue #7016: [FLINK-10772][release] Fix
create_binary_release.sh
URL: https://github.com/apache/flink/pull/7016#issuecomment-435794892
Thanks for the review @zentol. I think it works for the `1.6.x` release
because we introduced the dependency on `flink-runtime:test-jar` with `1.7`.
Before this was not present.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> create_binary_release.sh is broken
> ----------------------------------
>
> Key: FLINK-10772
> URL: https://issues.apache.org/jira/browse/FLINK-10772
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.6.2, 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The {{create_binary_release.sh}} is broken because it calls a script which
> does not exist. In fact, this script no longer needs to be called.
> Moreover, the build fails because we skip the compilation and packaging of
> test dependencies via {{-Dmaven.test.skip=true}}. The problem is that test
> dependencies are still being resolved if this property is specified. See
> MJAR-138 for more information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
