[
https://issues.apache.org/jira/browse/FLINK-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704601#comment-14704601
]
Aljoscha Krettek edited comment on FLINK-2551 at 8/20/15 9:47 AM:
------------------------------------------------------------------
All of them except {{TypeSerializerInputFormat}} are easy to fix. For
{{TypeSerializerInputFormat}} is see three possible solutions:
- Revert to the old version that takes a serializer instead of a TypeInfo
- Add a new interface akin to {{InputTypeConfigurable}} but for the output type
- Make TypeInformation actually serializable and initialize the Serializer in
the {{open}} method of {{TypeSerializerInputFormat}} at runtime.
The first would be easiest but API breaking, the second would be ok, the third
would be rather big and we probably don't want to have TypeInformation
serializable even though it technically is already.
What do you think?
was (Author: aljoscha):
All of them except {{TypeSerializerInputFormat}} are easy to fix. For
{{TypeSerializerInputFormat}} is see three possible solutions:
- Revert to the old version that takes a serializer instead of a TypeInfo
- Add a new interface akin to {{InputTypeConfigurable}} but for the output type
- Make TypeInformation actually serializable and initialize the Serializer in
the {{open}} method of {{TypeSerializerInputFormat}} at runtime.
The first would be easiest but API breaking, the second would be ok, the third
would be rather big and we probably don't want to have TypeInformation
serializable even though it technically is already.
> Fix Several Bugs in Input/Output Formats
> ----------------------------------------
>
> Key: FLINK-2551
> URL: https://issues.apache.org/jira/browse/FLINK-2551
> Project: Flink
> Issue Type: Bug
> Affects Versions: 0.9
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> This is a collection of several things that are wrong (or possibly
> problematic) in the handling of Input/Output formats.
> The things I have so far:
> - TypeSerializerInputFormat was changed to take a TypeInformation instead of
> a TypeSerialzer. The javadoc is not updated, however
> - This lead to another bug: When the serializer is created from the
> TypeInformation it is not given the correct ExecutionConfig from the
> ExecutionEnvironment and thus custom serializers don't work. (This one, I
> broke)
> - In BinaryOutputFormat some fields are not declared transient even though
> they should be
> - The Streaming API does not call {{setInputType}} if a format implements
> {{InputTypeConfigurable}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
