pnowojski commented on a change in pull request #7023: [FLINK-10711] [e2e] Allow basic error handling with bash URL: https://github.com/apache/flink/pull/7023#discussion_r230767200
########## File path: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh ########## @@ -17,8 +17,6 @@ # limitations under the License. ################################################################################ -set -o pipefail Review comment: My comment was not targeted to `elasticsearch-common.sh` alone, but to all of the scripts. Do we want to assume that `test-scripts/common.sh` is included before anything else anywhere? I mean we could, but that can be quite fragile convention. On the other hand, I don't want to overthink this, since we would like to start replacing those bash scripts after 1.7 release anyway. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
