[ 
https://issues.apache.org/jira/browse/FLINK-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679755#comment-16679755
 ] 

ASF GitHub Bot commented on FLINK-10686:
----------------------------------------

xueyumusic opened a new pull request #7059: [FLINK-10686][table] Port UDFs in 
Table API extension points to flink-table-common
URL: https://github.com/apache/flink/pull/7059
 
 
   ## What is the purpose of the change
   
   This PR tries to port UDFs interfaces of TableApi extension points to 
flink-table-common in java. Right now  it ports UserDefinedFunction, 
ScalarFunction, TableFunction, AggregateFunction, DistinctAggregateFunction in 
org.apache.flink.table.functions execpt FunctionService and 
TemporalTableFunction. FunctionService and TemporalTableFunction may be could 
be ported following.
   
   
   ## Brief change log
   
   *(for example:)*
     - *port several scala file in org.apache.flink.table.functions to java *
   
   ## Verifying this change
   
   This change is a code refactor with existed tests.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Introduce a flink-table-common module
> -------------------------------------
>
>                 Key: FLINK-10686
>                 URL: https://issues.apache.org/jira/browse/FLINK-10686
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.7.0
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.8.0
>
>
> Because more and more table factories for connectors and formats are added 
> and external catalog support is also on the horizon, {{flink-table}} becomes 
> a dependency for many Flink modules. Since {{flink-table}} is implemented in 
> Scala it requires other modules to be suffixes with Scala prefixes. However, 
> as we have learned in the past, Scala code is hard to maintain which is why 
> our long-term goal is to avoid Scala/Scala dependencies.
> Therefore we propose a new module {{flink-table-common}} that contains 
> interfaces between {{flink-table}} and other modules. This module is 
> implemented in Java and should contain minimal (or better no) external 
> dependencies.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to