[
https://issues.apache.org/jira/browse/FLINK-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679951#comment-16679951
]
ASF GitHub Bot commented on FLINK-10624:
----------------------------------------
pnowojski commented on a change in pull request #6927: [FLINK-10624] Extend SQL
client end-to-end to test new KafkaTableSink
URL: https://github.com/apache/flink/pull/6927#discussion_r231950736
##########
File path: flink-end-to-end-tests/test-scripts/test_sql_client_common.sh
##########
@@ -17,8 +17,6 @@
# limitations under the License.
################################################################################
-set -Eeuo pipefail
-
source "$(dirname "$0")"/common.sh
source "$(dirname "$0")"/kafka-common.sh 0.10.2.0 3.2.0 3.2
source "$(dirname "$0")"/elasticsearch-common.sh
Review comment:
Have you forgotten to remove those imports?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Extend SQL client end-to-end to test new KafkaTableSink
> -------------------------------------------------------
>
> Key: FLINK-10624
> URL: https://issues.apache.org/jira/browse/FLINK-10624
> Project: Flink
> Issue Type: Sub-task
> Components: Kafka Connector, Table API & SQL, Tests
> Affects Versions: 1.7.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> With FLINK-9697, we added support for Kafka 2.0. We should also extend the
> existing streaming client end-to-end test to also test the new
> {{KafkaTableSink}} against Kafka 2.0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
