[ 
https://issues.apache.org/jira/browse/FLINK-8997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679625#comment-16679625
 ] 

ASF GitHub Bot commented on FLINK-8997:
---------------------------------------

kl0u commented on a change in pull request #7039: [FLINK-8997] Added sliding 
window aggregation to datastream test job
URL: https://github.com/apache/flink/pull/7039#discussion_r231847473
 
 

 ##########
 File path: 
flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/DataStreamAllroundTestProgram.java
 ##########
 @@ -150,6 +156,24 @@ public void apply(Integer integer, TimeWindow window, 
Iterable<Event> input, Col
                                .name(FAILURE_MAPPER_NAME);
                }
 
+               DataStream<Tuple2<Integer, List<Event>>> eventStream4 = 
eventStream2.keyBy(Event::getKey)
+                       .window(createSlidingWindow(pt))
 
 Review comment:
   Add names to the operators as done in the rest of the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add sliding window aggregation to the job
> -----------------------------------------
>
>                 Key: FLINK-8997
>                 URL: https://issues.apache.org/jira/browse/FLINK-8997
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Stefan Richter
>            Assignee: Dawid Wysakowicz
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> The test job should also test windowing. Sliding windows are probably the 
> most demanding form, so this would be a good pick for the test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to